From: Dan Carpenter Date: Fri, 1 Mar 2013 20:28:06 +0000 (+0300) Subject: Staging: bcm: potential forever loop verifying firmware X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~137^2~788 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c5270ac807e46889fb08c3cf3c65902d0c35bb2;p=pandora-kernel.git Staging: bcm: potential forever loop verifying firmware There is an ioctl() to write data to the firmware. After the data is written, it reads the databack from the firmware and compares against what the user wanted to write and prints an error message if it doesn't match. The problem is that verify process has a forever loop if the firmware size is not a multiple of 4. I've fixed it by replacing the bcm compare function with memcmp(). I have chopped out some debugging code in the process. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed