From: Mark Fasheh Date: Tue, 19 May 2015 19:49:50 +0000 (-0700) Subject: btrfs: clear 'ret' in btrfs_check_shared() loop X-Git-Tag: omap-for-v4.2/wakeirq-drivers-v2^2~2^2~63^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c2ed5aa0154c0be67f98c970de6b5587dbc045a;p=pandora-kernel.git btrfs: clear 'ret' in btrfs_check_shared() loop btrfs_check_shared() is leaking a return value of '1' from find_parent_nodes(). As a result, callers (in this case, extent_fiemap()) are told extents are shared when they are not. This in turn broke fiemap on btrfs for kernels v3.18 and up. The fix is simple - we just have to clear 'ret' after we are done processing the results of find_parent_nodes(). It wasn't clear to me at first what was happening with return values in btrfs_check_shared() and find_parent_nodes() - thanks to Josef for the help on irc. I added documentation to both functions to make things more clear for the next hacker who might come across them. If we could queue this up for -stable too that would be great. Signed-off-by: Mark Fasheh Reviewed-by: Josef Bacik Signed-off-by: Chris Mason --- Reading git-diff-tree failed