From: Chen Gang Date: Thu, 25 Apr 2013 00:49:55 +0000 (+0000) Subject: net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~77^2~15^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2c1bbbffa0b644fab4f91878cde0c2e8f52e2dcc;p=pandora-kernel.git net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not succeed. This bug can be boiled down to ``u8 foo = 0xff; if (foo == ~(u8)0) [...] else [...]'' where the condition will always take the else branch. Signed-off-by: Chen Gang Signed-off-by: David S. Miller --- Reading git-diff-tree failed