From: Arend van Spriel Date: Sat, 4 Jan 2014 12:51:26 +0000 (+0100) Subject: sdhci: only reprogram retuning timer when flag is set X-Git-Tag: v3.15-rc1~42^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2bc024855e881c697fc9bf9799f377c392192a43;p=pandora-kernel.git sdhci: only reprogram retuning timer when flag is set When the host->tuning_count is zero it means that the retuning is disabled. This is checked on the first run of sdhci_execute_tuning() by the if statement below: if (!(host->flags & SDHCI_NEEDS_RETUNING) && host->tuning_count && (host->tuning_mode == SDHCI_TUNING_MODE_1)) { So only when tuning_count is non-zero it will set the host flag SDHCI_USING_RETUNING_TIMER. The else statement is only for re-programming the timer, which means that flag must be set. Because that is not checked the else statement is executed in the first run when tuning_count is zero. This was seen on a host controller which indicated SDHCI_TUNING_MODE_1 (0) and tuning_count being zero. Suspect that (one of) these registers is not properly set. Signed-off-by: Arend van Spriel Acked-by: Ulf Hansson Reviewed-by: Aaron Lu Signed-off-by: Chris Ball --- Reading git-diff-tree failed