From: Thomas Renninger Date: Fri, 1 Oct 2010 08:53:59 +0000 (+0200) Subject: ACPI: Do not export hid/modalias sysfs file for ACPI objects without a HID X-Git-Tag: v2.6.37-rc1~100^2~10^4~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2b2ae7c7f8e25043793042eb9df88aa875b4cff8;p=pandora-kernel.git ACPI: Do not export hid/modalias sysfs file for ACPI objects without a HID Boot and compile tested. The fact that pnp.ids can now be empty needs testing on some further machines, though. This should handle a "modprobe is wrongly called by udev" issue: https://bugzilla.kernel.org/show_bug.cgi?id=19162 Modaliase files in /sys/devices/LNXSYSTM:00/ went down from 113 to 71 on my tested system. This is a sysfs change, but userspace must already be able to handle it. Also do not fill up pnp.ids list with a "struct hid" entry. This comment: * This generic ID isn't useful for driver binding, but it provides * the useful property that "every acpi_device has an ID." is still half way true: Best you never touch pnp.ids list directly or make sure it can be empty, instead use: char *acpi_device_hid() which always returns a value ("device" as a dummy if the object has no hid). Signed-off-by: Thomas Renninger CC: Zhang Rui CC: kay.sievers@vrfy.org CC: Bjorn Helgaas Signed-off-by: Len Brown --- Reading git-diff-tree failed