From: Julia Lawall Date: Tue, 6 Apr 2010 21:34:48 +0000 (-0700) Subject: drivers/gpio/timbgpio.c: add missing unlock X-Git-Tag: v2.6.34-rc4~53 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a481800caf78f4750cc673c8baed12b5d703ff6;p=pandora-kernel.git drivers/gpio/timbgpio.c: add missing unlock In an error handling case the lock is not unlocked. The return is converted to a goto, to share the unlock at the end of the function. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression E1; identifier f; @@ f (...) { <+... * spin_lock_irqsave (E1,...); ... when != E1 * return ...; ...+> } // Signed-off-by: Julia Lawall Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed