From: Julia Lawall Date: Mon, 21 Jan 2013 13:02:50 +0000 (+0100) Subject: drivers/net/wireless/iwlegacy/4965-mac.c: adjust duplicate test X-Git-Tag: v3.9-rc1~139^2~2^2^2~42^2~46 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=29d7b331c73c4f1a8b3f7f4a94abe4eb834be351;p=pandora-kernel.git drivers/net/wireless/iwlegacy/4965-mac.c: adjust duplicate test Delete successive tests to the same location. This looks like simple code duplication. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @s exists@ local idexpression y; expression x,e; @@ *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) { ... when forall return ...; } ... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\) when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\) *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) { ... when forall return ...; } // Signed-off-by: Julia Lawall Signed-off-by: John W. Linville --- Reading git-diff-tree failed