From: Eric Dumazet Date: Wed, 25 May 2011 07:34:04 +0000 (+0000) Subject: net: hold rtnl again in dump callbacks X-Git-Tag: v3.0-rc1~147^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2907c35ff64708065e5a7fd54e8ded8263eb3074;p=pandora-kernel.git net: hold rtnl again in dump callbacks Commit e67f88dd12f6 (dont hold rtnl mutex during netlink dump callbacks) missed fact that rtnl_fill_ifinfo() must be called with rtnl held. Because of possible deadlocks between two mutexes (cb_mutex and rtnl), its not easy to solve this problem, so revert this part of the patch. It also forgot one rcu_read_unlock() in FIB dump_rules() Add one ASSERT_RTNL() in rtnl_fill_ifinfo() to remind us the rule. Signed-off-by: Eric Dumazet CC: Patrick McHardy CC: Stephen Hemminger Signed-off-by: David S. Miller --- Reading git-diff-tree failed