From: Stephan Gerhold <stephan.gerhold@linaro.org>
Date: Mon, 7 Apr 2025 11:10:00 +0000 (+0200)
Subject: IOMUX: Fix stopping unused dropped consoles
X-Git-Tag: v2025.07-rc1~66
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=265420ebc10bc96275be5eb81fe6157d46e135d4;p=pandora-u-boot.git

IOMUX: Fix stopping unused dropped consoles

iomux_match_device() returns -ENOENT instead of the end index, which means
console_stop() is never called at the moment for unused consoles.

This prevents e.g. f_acm from releasing the USB gadget interface when
removing it from stdio/stderr/stdin.

Fixes: b672c1619bb9 ("IOMUX: Split out iomux_match_device() helper")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

diff --git a/common/iomux.c b/common/iomux.c
index 1224c15eb71..4844df51fbe 100644
--- a/common/iomux.c
+++ b/common/iomux.c
@@ -131,7 +131,7 @@ int iomux_doenv(const int console, const char *arg)
 	/* Stop dropped consoles */
 	for (i = 0; i < repeat; i++) {
 		j = iomux_match_device(cons_set, cs_idx, old_set[i]);
-		if (j == cs_idx)
+		if (j == -ENOENT)
 			console_stop(console, old_set[i]);
 	}