From: Dan Carpenter Date: Tue, 2 Oct 2012 08:32:34 +0000 (+0300) Subject: orinoco_usb: clean up some signedness issues X-Git-Tag: omap-for-v3.8/fixes-for-merge-window-v4-signed~45^2~337^2^2~87 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=264e989a0b347c61bd3258063eac8b86f55ff037;p=pandora-kernel.git orinoco_usb: clean up some signedness issues In ezusb_read_ltv() we had a comparison "(bufsize < 0)" which was never true because bufsize was unsigned. I looked at the implications of that. If we passed a negative number to ezusb_access_ltv() then it would be used as the size parameter of the memcpy() because that function uses min_t(int, exp_len, ans_size). But fortunately when I looked at the callers, bufsize is not controlled by the user and it's never negative. So these signedness mistakes have no impact. I removed the always false check from ezusb_read_ltv() and I changed the types in ezusb_access_ltv() and made the variables unsigned. Signed-off-by: Dan Carpenter Signed-off-by: John W. Linville --- Reading git-diff-tree failed