From: Ben Hutchings Date: Mon, 30 Aug 2010 14:15:33 +0000 (+0000) Subject: 3c59x: Remove incorrect locking; correct documented lock hierarchy X-Git-Tag: v2.6.36-rc4~87^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24cd804d1dc60a74c53da983094df3516500c276;p=pandora-kernel.git 3c59x: Remove incorrect locking; correct documented lock hierarchy vortex_ioctl() was grabbing vortex_private::lock around its call to generic_mii_ioctl(). This is no longer necessary since there are more specific locks which the mdio_{read,write}() functions will obtain. Worse, those functions do not save and restore IRQ flags when locking the MII state, so interrupts will be enabled when generic_mii_ioctl() returns. Since there is currently no need for any function to call mdio_{read,write}() while holding another spinlock, do not change them to save and restore IRQ flags but remove the specification of ordering between vortex_private::lock and vortex_private::mii_lock. Signed-off-by: Ben Hutchings Signed-off-by: David S. Miller --- Reading git-diff-tree failed