From: NeilBrown Date: Tue, 11 Apr 2006 05:55:24 +0000 (-0700) Subject: [PATCH] knfsd: nfsd4: Wrong error handling in nfs4acl X-Git-Tag: v2.6.17-rc2~128 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=249920527f9e6e5c305538bbf1ea882ee7dc1c06;p=pandora-kernel.git [PATCH] knfsd: nfsd4: Wrong error handling in nfs4acl this fixes coverity id #3. Coverity detected dead code, since the == -1 comparison only returns 0 or 1 to error. Therefore the if ( error < 0 ) statement was always false. Seems that this was an if( error = nfs4... ) statement some time ago, which got broken during cleanup. Signed-off-by: Eric Sesterhenn Signed-off-by: J. Bruce Fields Signed-off-by: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed