From: Jeff Layton Date: Wed, 16 Jun 2010 17:40:16 +0000 (-0400) Subject: cifs: move cifs_new_fileinfo call out of cifs_posix_open X-Git-Tag: v2.6.35-rc4~66^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2422f676fb78942d054f7e7a2c3ceaeb7945d814;p=pandora-kernel.git cifs: move cifs_new_fileinfo call out of cifs_posix_open Having cifs_posix_open call cifs_new_fileinfo is problematic and inconsistent with how "regular" opens work. It's also buggy as cifs_reopen_file calls this function on a reconnect, which creates a new struct cifsFileInfo that just gets leaked. Push it out into the callers. This also allows us to get rid of the "mnt" arg to cifs_posix_open. Finally, in the event that a cifsFileInfo isn't or can't be created, we always want to close the filehandle out on the server as the client won't have a record of the filehandle and can't actually use it. Make sure that CIFSSMBClose is called in those cases. Signed-off-by: Jeff Layton Reviewed-and-Tested-by: Suresh Jayaraman --- Reading git-diff-tree failed