From: Rusty Russell Date: Mon, 15 Jul 2013 01:51:32 +0000 (+0930) Subject: s390: Replace weird use of PTR_RET. X-Git-Tag: v3.12-rc1~146^2~11 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=228b82211b47b597fa75dff2ac146b40eaaddf18;p=pandora-kernel.git s390: Replace weird use of PTR_RET. Saves repeating "(void __force *)__uptr" but it's less clear. Using the output of PTR_RET() to determine the error rather than just testing IS_ERR() is odd. For example, I *assume* __gptr_to_uptr() never returns NULL? Because the __ret would be 0 for the old code. The new version is clearer, IMHO: it would try to get_user() on that address. If you hate this variant, I can just s/PTR_RET/PTR_ERR_OR_ZERO/ instead. Cc: Christian Borntraeger Cc: Martin Schwidefsky Signed-off-by: Rusty Russell Acked-by: Heiko Carstens --- Reading git-diff-tree failed