From: Linus Torvalds Date: Tue, 25 May 2010 23:48:30 +0000 (-0700) Subject: Revert "module: drop the lock while waiting for module to complete initialization." X-Git-Tag: v2.6.35-rc1~263 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=218ce7351413b8287a80fab1d7b94906a5559f01;p=pandora-kernel.git Revert "module: drop the lock while waiting for module to complete initialization." This reverts commit 480b02df3aa9f07d1c7df0cd8be7a5ca73893455, since Rafael reports that it causes occasional kernel paging request faults in load_module(). Dropping the module lock and re-taking it deep in the call-chain is definitely not the right thing to do. That just turns the mutex from a lock into a "random non-locking data structure" that doesn't actually protect what it's supposed to protect. Requested-and-tested-by: Rafael J. Wysocki Cc: Rusty Russell Cc: Brandon Philips Cc: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed