From: Mathias Krause <minipli@googlemail.com>
Date: Fri, 21 Feb 2014 20:38:34 +0000 (+0100)
Subject: pktgen: fix out-of-bounds access in pgctrl_write()
X-Git-Tag: v3.15-rc1~113^2~281
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=20b0c718c3bb122107bebadbb8ecf4bab76fb392;p=pandora-kernel.git

pktgen: fix out-of-bounds access in pgctrl_write()

If a privileged user writes an empty string to /proc/net/pktgen/pgctrl
the code for stripping the (then non-existent) '\n' actually writes the
zero byte at index -1 of data[]. The then still uninitialized array will
very likely fail the command matching tests and the pr_warning() at the
end will therefore leak stack bytes to the kernel log.

Fix those issues by simply ensuring we're passed a non-empty string as
the user API apparently expects a trailing '\n' for all commands.

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed