From: Masatake YAMATO Date: Wed, 10 Apr 2013 16:24:38 +0000 (-0500) Subject: [SCSI] libiscsi: avoid unnecessary multiple NULL assignments X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~95^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1fc2b00fba55f70ab32ecc493efbca9a1a76a4e3;p=pandora-kernel.git [SCSI] libiscsi: avoid unnecessary multiple NULL assignments In iscsi_free_task, NULL is assigned to task->sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session->lock, so multiple NULL assignments cause no trouble. But people reading the source code may be confused. The second NULL assignment comes from commit: 3e5c28ad0391389959ccae81c938c7533efb3490 It seems that the line after kfifo_in invocation was introduced accidentally. Signed-off-by: Masatake YAMATO Signed-off-by: Mike Christie Signed-off-by: James Bottomley --- Reading git-diff-tree failed