From: Andy Grover <agrover@redhat.com>
Date: Thu, 19 Jan 2012 21:39:23 +0000 (-0800)
Subject: target: Change target_submit_cmd() to return void
X-Git-Tag: v3.3-rc3~2^2~7
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1edcdb497ef418122cd4f98e157660cf594b345a;p=pandora-kernel.git

target: Change target_submit_cmd() to return void

Retval not very useful, and may even be harmful. Once submitted, fabrics
should expect a sense error if anything goes wrong. All fabrics checking
of this retval are useless or broken:

fc checks it just to emit more debug output.
ib_srpt trickles retval up, then it is ignored.
qla2xxx trickles it up, which then causes a bug because the abort goto
in qla_target.c thinks cmd hasn't been sent to target.

Just returning nothing is best.

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---

Reading git-diff-tree failed