From: Bjorn Helgaas Date: Tue, 29 Apr 2014 18:51:55 +0000 (-0600) Subject: PCI: Fix use of uninitialized MPS value X-Git-Tag: omap-for-v3.16/fixes-against-rc1~38^2~9^5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1e358f94c00570f88a590cabe718daf835440cc9;p=pandora-kernel.git PCI: Fix use of uninitialized MPS value If "pcie_bus_config == PCIE_BUS_PERFORMANCE", we don't initialize "smpss", so we pass a pointer to garbage into pcie_bus_configure_set(), where we compute "mps" based on the garbage. We then pass the garbage "mps" to pcie_write_mps(), which ignores it in the PCIE_BUS_PERFORMANCE case. Coverity isn't smart enough to deduce that we ignore the garbage (it's a lot to expect from a human, too), so initialize "smpss" to a safe value in all cases. Found by Coverity (CID 146454). Signed-off-by: Bjorn Helgaas --- Reading git-diff-tree failed