From: Hans Verkuil Date: Mon, 4 Mar 2013 10:18:38 +0000 (-0300) Subject: [media] davinci/dm644x_ccdc: fix compiler warning X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~81^2~471 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1de1951930d4450d1645a0a907b710f268af42c3;p=pandora-kernel.git [media] davinci/dm644x_ccdc: fix compiler warning drivers/media/platform/davinci/dm644x_ccdc.c: In function ‘validate_ccdc_param’: drivers/media/platform/davinci/dm644x_ccdc.c:233:32: warning: comparison between ‘enum ccdc_gama_width’ and ‘enum ccdc_data_size’ [-Wenum-compare] It took a bit of work, see this thread of an earlier attempt to fix this: https://patchwork.kernel.org/patch/1923091/ I've chosen not to follow the suggestions in that thread since gamma_width is really a different property from data_size. What you really want is to know if gamma_width fits inside data_size and for that you need to translate each enum into a maximum bit number so you can safely compare the two. So I put in two static inline translation functions instead, keeping the rest of the code the same (except for fixing the 'gama' typo). Signed-off-by: Hans Verkuil Acked-by: Lad, Prabhakar Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed