From: Jean Delvare Date: Tue, 19 Apr 2005 04:16:59 +0000 (-0700) Subject: [PATCH] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers X-Git-Tag: v2.6.12-rc3~25^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1d66c64c3cee10a465cd3f8bd9191bbeb718f650;p=pandora-kernel.git [PATCH] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers The it87 and via686a hardware monitoring drivers each create a sysfs file named "alarms" in R/W mode, while they should really create it in read-only mode. Since we don't provide a store function for these files, write attempts to these files will do something undefined (I guess) and bad (I am sure). My own try resulted in a locked terminal (where I attempted the write) and a 100% CPU load until next reboot. As a side note, wouldn't it make sense to check, when creating sysfs files, that readable files have a non-NULL show method, and writable files have a non-NULL store method? I know drivers are not supposed to do stupid things, but there is already a BUG_ON for several conditions in sysfs_create_file, so maybe we could add two more? Signed-off-by: Jean Delvare Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed