From: Ian Abbott <abbotti@mev.co.uk>
Date: Wed, 3 Oct 2012 15:25:19 +0000 (+0100)
Subject: staging: comedi: amplc_pc263: fix possible NULL deref during detach
X-Git-Tag: v3.7-rc3~13^2~14
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1d1171ffda585c1cab7bd7cf4bd8f8fd5923fb4a;p=pandora-kernel.git

staging: comedi: amplc_pc263: fix possible NULL deref during detach

`pc263_detach()` is called by the comedi core to clean up if either
`pc263_attach()` or `pc263_attach_pci()` returns an error.  It sets
`thisboard` to the return value of `comedi_board(dev)` and assumes it is
non-null.  This is a valid assumption if `pc263_attach()` fails, but not
if `pc263_attach_pci()` fails, leading to a possible NULL pointer
dereference.

Check `thisboard` at the top of `pc263_detach()` and return early if it
is `NULL`.  This is okay because no other resources need cleaning up in
this case.

Cc: <stable@vger.kernel.org> # 3.6.x
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

Reading git-diff-tree failed