From: H Hartley Sweeten Date: Mon, 20 May 2013 21:31:32 +0000 (-0700) Subject: staging: comedi: usbduxsigma: consolidate the firmware upload X-Git-Tag: omap-for-v3.11/fixes-for-merge-window~76^2~527 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1cf35b51bea0201fd4552b3d83aaef4dcecf5187;p=pandora-kernel.git staging: comedi: usbduxsigma: consolidate the firmware upload Absorb the usbduxsub_stop(), usbduxsub_upload(), and usbduxsub_start() functions into firmwareUpload(). Each of them just do a usb_control_msg() to the device and output an error message if it fails. A similar message is also output by firmware_upload() so the extra messages are redundant. We can also share the malloc'ed local buffer needed for the usb_control_msg(). Signed-off-by: H Hartley Sweeten Cc Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed