From: Oded Gabbay Date: Mon, 10 Nov 2014 10:21:39 +0000 (+0200) Subject: iommu/amd: Fix accounting of device_state X-Git-Tag: omap-for-v3.19/fixes-rc1~106^2^7 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1c51099a427dc8bfee917b2d0e53ad3fafbb930d;p=pandora-kernel.git iommu/amd: Fix accounting of device_state This patch fixes a bug in the accounting of the device_state. In the current code, the device_state was put (decremented) too many times, which sometimes lead to the driver getting stuck permanently in put_device_state_wait(). That happen because the device_state->count would go below zero, which is never supposed to happen. The root cause is that the device_state was decremented in put_pasid_state() and put_pasid_state_wait() but also in all the functions that call those functions. Therefore, the device_state was decremented twice in each of these code paths. The fix is to decouple the device_state accounting from the pasid_state accounting - remove the call to put_device_state() from the put_pasid_state() and the put_pasid_state_wait()) Signed-off-by: Oded Gabbay Signed-off-by: Joerg Roedel --- Reading git-diff-tree failed