From: Stefan Richter Date: Mon, 16 Aug 2010 21:45:54 +0000 (+0200) Subject: firewire: net: fix unicast reception RCODE in failure paths X-Git-Tag: v2.6.36-rc3~1^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bf145fed572583d4cb7c1784689a0b42c997ba6;p=pandora-kernel.git firewire: net: fix unicast reception RCODE in failure paths The incoming request hander fwnet_receive_packet() expects subsequent datagram handling code to return non-zero on errors. However, almost none of the failure paths did so. Fix them all. (This error reporting is used to send and RCODE_CONFLICT_ERROR to the sender node in such failure cases. Two modes of failure exist: Out of memory, or firewire-net is unaware of any peer node to which a fragment or an ARP packet belongs. However, it is unclear whether a sender can actually make use of such information. A Linux peer apparently can't. Maybe it should all be simplified to void functions.) Reported-by: Julia Lawall Signed-off-by: Stefan Richter --- Reading git-diff-tree failed