From: Anatolij Gustschin Date: Thu, 1 Jul 2010 17:21:39 +0000 (-0300) Subject: V4L/DVB: v4l2-dev: fix memory leak X-Git-Tag: v2.6.36-rc1~582^2~78 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bb6419433433e845f7bc47651ad246b2e65c6fa;p=pandora-kernel.git V4L/DVB: v4l2-dev: fix memory leak Since commit b4028437876866aba4747a655ede00f892089e14 the 'driver_data' field resides in device's struct device_private which may be allocated by dev_set_drvdata() if device_private struct was not allocated previously. dev_set_drvdata() is used in video_set_drvdata() to set the driver's private data pointer in v4l2 drivers. Setting the private data _before_ registering the v4l2 device results in a memory leak since __video_register_device() also calls video_set_drvdata(), but after zeroing the device structure. Thus, the reference to the previously allocated device_private struct goes lost and a new device_private will be allocated. All v4l drivers which call video_set_drvdata() _before_ calling video_register_device() are affected. The patch fixes __video_register_device() to preserve previously allocated device_private reference. Caught by kmemleak. Signed-off-by: Anatolij Gustschin Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed