From: Damien Lespiau Date: Wed, 21 Jan 2015 13:50:54 +0000 (+0000) Subject: drm/i915: Fix kzalloc() smatch warnings in get_initial_plane_config() X-Git-Tag: omap-for-v4.1/prcm-dts-mfd-syscon-fix~75^2~8^2~52 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b842c89bd8eb0e9619e1aba071c9a5529b7a179;p=pandora-kernel.git drm/i915: Fix kzalloc() smatch warnings in get_initial_plane_config() Smatch doesn't like: struct drm_framebuffer *fb; fb = kzalloc(sizeof(struct intel_framebuffer), GFP_KERNEL); and warns with: warn: struct type mismatch 'drm_framebuffer vs intel_framebuffer' This implicit cast was correct as struct intel_framebuffer has struct drm_framebuffer as its first member, but in case someone want to reorder the fields for some reason, it's slightly safer to access the underlying drm_framebuffer through intel_fb->base. Also, having fewer static analysis warnings is a worthy goal. Cc: kbuild@01.org Cc: Dan Carpenter Signed-off-by: Damien Lespiau Signed-off-by: Daniel Vetter --- Reading git-diff-tree failed