From: Richard Guy Briggs Date: Mon, 2 Dec 2013 16:33:01 +0000 (-0500) Subject: audit: drop audit_cmd_lock in AUDIT_USER family of cases X-Git-Tag: v3.14-rc1~118^2~21 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b7b533f65db9b31f76972b2899ec7ec6433ae77;p=pandora-kernel.git audit: drop audit_cmd_lock in AUDIT_USER family of cases We do not need to hold the audit_cmd_mutex for this family of cases. The possible exception to this is the call to audit_filter_user(), so drop the lock immediately after. To help in fixing the race we are trying to avoid, make sure that nothing called by audit_filter_user() calls audit_log_start(). In particular, watch out for *_audit_rule_match(). This fix will take care of systemd and anything USING audit. It still means that we could race with something configuring audit and auditd shutting down. Signed-off-by: Richard Guy Briggs Reported-by: toshi.okajima@jp.fujitsu.com Tested-by: toshi.okajima@jp.fujitsu.com Signed-off-by: Eric Paris --- Reading git-diff-tree failed