From: Julia Lawall Date: Mon, 29 Mar 2010 15:36:44 +0000 (+0200) Subject: USB: gadget: s3c-hsotg: Add missing unlock X-Git-Tag: v2.6.34-rc7~38^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=19c190f9e0fe926db28122a804111a7538dc3498;p=pandora-kernel.git USB: gadget: s3c-hsotg: Add missing unlock In an error handling case the lock is not unlocked. The return is converted to a goto, to share the unlock at the end of the function. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression E1; identifier f; @@ f (...) { <+... * spin_lock_irqsave (E1,...); ... when != E1 * return ...; ...+> } // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed