From: Andy Shevchenko Date: Fri, 12 Sep 2014 12:11:58 +0000 (+0300) Subject: spi: dw-mid: check that DMA was inited before exit X-Git-Tag: v3.2.65~140 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=186b5538352926f7e68d0c24a228307d21ae7f17;p=pandora-kernel.git spi: dw-mid: check that DMA was inited before exit commit 63d84b1a46957b3ecc56af8087220c0df42e0ef2 upstream. commit fb57862ead652454ceeb659617404c5f13bc34b5 upstream. If the driver was compiled with DMA support, but DMA channels weren't acquired by some reason, mid_spi_dma_exit() will crash the kernel. Fixes: 7063c0d942a1 (spi/dw_spi: add DMA support) Signed-off-by: Andy Shevchenko Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman Signed-off-by: Ben Hutchings --- diff --git a/drivers/spi/spi-dw-mid.c b/drivers/spi/spi-dw-mid.c index 66026ecf023f..c4dd7ef59855 100644 --- a/drivers/spi/spi-dw-mid.c +++ b/drivers/spi/spi-dw-mid.c @@ -88,6 +88,8 @@ err_exit: static void mid_spi_dma_exit(struct dw_spi *dws) { + if (!dws->dma_inited) + return; dma_release_channel(dws->txchan); dma_release_channel(dws->rxchan); }