From: Julia Lawall Date: Mon, 31 Aug 2009 19:34:25 +0000 (+0200) Subject: Staging: rtl8192e: Drop unnecessary NULL test X-Git-Tag: v2.6.32-rc1~668^2~21 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=18526c7896fca5229c8d7b4b415605a17f9952d0;p=pandora-kernel.git Staging: rtl8192e: Drop unnecessary NULL test The result of container_of should not be NULL. In particular, in this case the argument to the enclosing function has passed though INIT_WORK, which dereferences it, implying that its container cannot be NULL. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ identifier fn,work,x,fld; type T; expression E1,E2; statement S; @@ static fn(struct work_struct *work) { ... when != work = E1 x = container_of(work,T,fld) ... when != x = E2 - if (x == NULL) S ... } // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed