From: H Hartley Sweeten Date: Wed, 25 Sep 2013 22:35:50 +0000 (-0700) Subject: staging: comedi: pcl726: tidy up pcl726_ao_insn() X-Git-Tag: omap-for-v3.13/fixes-for-merge-window-take2~62^2~582 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1821e389ab651c63bc0d9370780be81c19a7c90c;p=pandora-kernel.git staging: comedi: pcl726: tidy up pcl726_ao_insn() For aesthetics, rename the function to help with greps. The offset binary value from the core should be saved for read back. Move the saving of the value in the private data so it occurs before the value is possibly munged for bipolar outputs. Use the comedi_offset_munge() helper to munge the offset binary value to two's complement for bipolar outputs. According to the November 2011 users manual, the write order must be MSB them LSB. Update the comment. Modify the register map defines to handle the channel offset calculation. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed