From: Julia Lawall Date: Sat, 20 Aug 2011 07:02:00 +0000 (+0200) Subject: sound/soc/fsl/p1022_ds.c: add missing of_node_put X-Git-Tag: v3.1-rc4~11^2^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=178b279b645a14ca8ea01e4ea818c88681a31b07;p=pandora-kernel.git sound/soc/fsl/p1022_ds.c: add missing of_node_put dma_channel_np has been accessed at this point, so decrease its reference count before leaving the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != of_node_put(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 of_node_put(x); ... return ...; } ) // Signed-off-by: Julia Lawall Acked-by: Liam Girdwood Signed-off-by: Mark Brown --- Reading git-diff-tree failed