From: Jesper Juhl Date: Thu, 3 May 2012 07:25:51 +0000 (+0300) Subject: wlcore: fix size of two memset's in wl1271_cmd_build_arp_rsp() X-Git-Tag: v3.5-rc1~101^2~6^2^2~86 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=161f17b5307ecf56484c1d0e0ae433506394651c;p=pandora-kernel.git wlcore: fix size of two memset's in wl1271_cmd_build_arp_rsp() We currently do this: int wl1271_cmd_build_arp_rsp(struct wl1271 *wl, struct wl12xx_vif *wlvif) ... struct wl12xx_arp_rsp_template *tmpl; struct ieee80211_hdr_3addr *hdr; ... tmpl = (struct wl12xx_arp_rsp_template *)skb_put(skb, sizeof(*tmpl)); memset(tmpl, 0, sizeof(tmpl)); ... hdr = (struct ieee80211_hdr_3addr *)skb_push(skb, sizeof(*hdr)); memset(hdr, 0, sizeof(hdr)); ... I believe we want to set the entire structures to 0 with those memset() calls, not just zero the initial part of them (size of the pointer bytes). Signed-off-by: Jesper Juhl Signed-off-by: Luciano Coelho --- Reading git-diff-tree failed