From: Jean Delvare Date: Wed, 1 Apr 2009 18:11:29 +0000 (-0500) Subject: SCSI: libiscsi: fix iscsi pool error path again X-Git-Tag: v2.6.27.22~31 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14ccf7620aad576505bbd545788009eeaed9e848;p=pandora-kernel.git SCSI: libiscsi: fix iscsi pool error path again upstream commit: fd6e1c14b73dbab89cb76af895d5612e4a8b5522 Le lundi 30 mars 2009, Chris Wright a écrit : > q->queue could be ERR_PTR(-ENOMEM) which will break unwinding > on error. Make iscsi_pool_free more defensive. > Making the freeing of q->queue dependent on q->pool being set looks really weird (although it is correct at the moment. But this seems to be fixable in a much simpler way. With the benefit that only the error case is slowed down. In both cases we have a problem if q->queue contains an error value but it's not -ENOMEM. Apparently this can't happen today, but it doesn't feel right to assume this will always be true. Maybe it's the right time to fix this as well. Signed-off-by: Mike Christie Signed-off-by: James Bottomley [chrisw: this is a fixlet to f474a37b, also in -stable] Signed-off-by: Chris Wright Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed