From: Stefan Richter Date: Sat, 5 Jun 2010 09:46:49 +0000 (+0200) Subject: firewire: ohci: do not enable interrupts without the handler X-Git-Tag: v2.6.36-rc1~490^2^3~58 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=148c7866c31d93f8c79366189075f5a26ad4556c;p=pandora-kernel.git firewire: ohci: do not enable interrupts without the handler On 26 Apr 2010, Clemens Ladisch wrote: > In theory, none of the interrupts should occur before the link is > enabled. In practice, I'd rather make sure to not set the master > interrupt enable bit until we have installed the interrupt handler. and proposed to move OHCI1394_masterIntEnable out of the present reg_write() into a new one before the HCControl.linkEnable reg_write(). Why not defer setting /all/ of the bits until right before linkEnable? Reviewed-by: Clemens Ladisch Signed-off-by: Stefan Richter --- Reading git-diff-tree failed