From: Julia Lawall Date: Fri, 31 Jul 2009 08:42:00 +0000 (+0930) Subject: fujitsu-laptop: Correct redundant test X-Git-Tag: v2.6.32-rc1~171^2~9^2~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14485c57270e8f3de2a25abaf93bae5712c97e9e;p=pandora-kernel.git fujitsu-laptop: Correct redundant test device and acpi_driver_data(device) were tested just a few lines above. A simplified version of the semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; @@ if (x == NULL || ...) { ... when forall return ...; } .. when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) ( *x == NULL | *x != NULL ) // Signed-off-by: Julia Lawall Acked-by: Jonathan Woithe Signed-off-by: Len Brown --- Reading git-diff-tree failed