From: Ville Syrjälä Date: Tue, 4 Jun 2013 10:49:07 +0000 (+0300) Subject: drm/i915: Assert dpll running in intel_crtc_load_lut() on pre-PCH platforms X-Git-Tag: v3.11-rc1~65^2~61^2~60 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=14420bd0065c1757a353e36ebc9cc4bdc6932dcd;p=pandora-kernel.git drm/i915: Assert dpll running in intel_crtc_load_lut() on pre-PCH platforms Adding more context from Ville's reply to Rodrigo's question why we need this: "The spec says that on some hardware you need to PLL running before you can poke at the palette registers. I didn't actually try to anger the hardware so I'm not really sure what would happen otherwise, but IIRC Jesse said something about a hard system hang..." And generally documenting such ordering constraints with asserts is Just Good. Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi [danvet: Spruce up the commit message a lot.] Signed-off-by: Daniel Vetter --- Reading git-diff-tree failed