From: adam radford Date: Wed, 11 Jan 2012 02:07:56 +0000 (-0800) Subject: [SCSI] megaraid: fix sparse warnings X-Git-Tag: v3.3-rc1~15^2~11 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=124dd90f6525ee785b47b59aebadd4a35f797dc1;p=pandora-kernel.git [SCSI] megaraid: fix sparse warnings There's a zero day mistake in the megaraid driver in that the code that obtains the version number does a >> 8 on a char quantity. This >>8 causes a sparse warning because it always produces zero. Al Viro suggested these shifts should be >> 4 thus treating the firmware version as a BCD quantity. However, in the interests of safety we've elected to replace the >> 8 quantities with an explicit zero, thus quieting the sparse warning while preserving the same (albeit incorrect) version number as had previously been seen. Signed-off-by: Adam Radford Signed-off-by: James Bottomley --- Reading git-diff-tree failed