From: Rusty Russell Date: Mon, 24 Nov 2008 23:29:20 +0000 (+1030) Subject: sched: avoid stack var in move_task_off_dead_cpu, fix X-Git-Tag: v2.6.29-rc1~538^2~31 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1224e376f2a7e3c7ab19ef37099a78597978a696;p=pandora-kernel.git sched: avoid stack var in move_task_off_dead_cpu, fix Impact: locking fix We can't call cpuset_cpus_allowed_locked() with the rq lock held. However, the rq lock merely protects us from (1) cpu_online_mask changing and (2) someone else changing p->cpus_allowed. The first can't happen because we're being called from a cpu hotplug notifier. The second doesn't really matter: we are forcing the task off a CPU it was affine to, so we're not doing very well anyway. So we remove the rq lock from this path, and all is good. Signed-off-by: Rusty Russell Acked-by: Mike Travis Signed-off-by: Ingo Molnar --- Reading git-diff-tree failed