From: Julia Lawall <julia@diku.dk>
Date: Thu, 27 May 2010 12:32:09 +0000 (+0200)
Subject: USB: serial: digi_acceleport: Eliminate a NULL pointer dereference
X-Git-Tag: v2.6.35-rc2~17^2~1
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=109f34e71b9049a57f6cdf3f1da6bee2b722b259;p=pandora-kernel.git

USB: serial: digi_acceleport: Eliminate a NULL pointer dereference

If port is NULL, then the call to dev_err will dereference a value that is
a small offset from NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

Reading git-diff-tree failed