From: Thomas Gleixner Date: Mon, 14 Feb 2011 17:08:51 +0000 (+0100) Subject: gpio/sx150x: Do not access I2C from mask/unmask functions X-Git-Tag: v2.6.39-rc1~417^2~22 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ff56cd85a2c5104a36d84662b9180c219e8604e;p=pandora-kernel.git gpio/sx150x: Do not access I2C from mask/unmask functions irq_chip->irq_mask/unmask are called with interrupts disabled and irq_desc->lock held. So we cannot access i2c from this context. That's what irq_bus_sync_unlock() is for. Store the masked information in the chip data structure and update the i2c bus from the irq_bus_sync_unlock() callback. This does not need a while(pending) loop because the update to this is always serialized via the bus lock, so we never have more than one pin update pending. Signed-off-by: Thomas Gleixner Cc: Andrew Morton Cc: Gregory Bean Cc: Jean Delvare Cc: Lennert Buytenhek Signed-off-by: Grant Likely --- Reading git-diff-tree failed