From: Daniel Mack Date: Wed, 2 Apr 2014 09:46:51 +0000 (+0200) Subject: usb: musb: dsps: move debugfs_remove_recursive() X-Git-Tag: omap-for-v3.16/pm-signed~48^2~20^2~8 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0fca91b8a446d4a38b8f3d4772c4a8665ebcd7b2;p=pandora-kernel.git usb: musb: dsps: move debugfs_remove_recursive() When the platform initialization fails due to missing resources, it will return -EPROBE_DEFER after dsps_musb_init() has been called. dsps_musb_init() calls dsps_musb_dbg_init() to allocate the debugfs nodes. At a later point in time, the probe will be retried, and dsps_musb_dbg_init() will be called again. debugfs_create_dir() will fail this time, as the node already exists, and so the entire device probe will fail with -ENOMEM. Fix this by moving debugfs_remove_recursive() from dsps_remove() to the plaform's exit function, so it will be cleanly torn down when the probe fails. It also feels more natural this way, as .exit is the counterpart to .init. Signed-off-by: Daniel Mack Signed-off-by: Felipe Balbi --- Reading git-diff-tree failed