From: Krzysztof Kozlowski Date: Wed, 15 Oct 2014 14:25:09 +0000 (+0200) Subject: power: bq2415x_charger: Properly handle ENODEV from power_supply_get_by_phandle X-Git-Tag: omap-for-v3.19/fixes-for-merge-window~106^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0eaf437aa14949d2230aeab7364f4ab47901304a;p=pandora-kernel.git power: bq2415x_charger: Properly handle ENODEV from power_supply_get_by_phandle The power_supply_get_by_phandle() on error returns ENODEV or NULL. The driver later expects obtained pointer to power supply to be valid or NULL. If it is not NULL then it dereferences it in bq2415x_notifier_call() which would lead to dereferencing ENODEV-value pointer. Properly handle the power_supply_get_by_phandle() error case by replacing error value with NULL. This indicates that usb charger detection won't be used. Fix also memory leak of 'name' if power_supply_get_by_phandle() fails with NULL and probe should defer. Signed-off-by: Krzysztof Kozlowski Fixes: faffd234cf85 ("bq2415x_charger: Add DT support") Cc: [small fix regarding the missing ti,usb-charger-detection info message] Signed-off-by: Sebastian Reichel --- Reading git-diff-tree failed