From: Alexey Khoroshilov Date: Sat, 25 Apr 2015 01:07:03 +0000 (+0300) Subject: pxa168: fix double deallocation of managed resources X-Git-Tag: omap-for-v4.2/omap1-v2~58^2~9 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0e03fd3e335d272bee88fe733d5fd13f5c5b7140;p=pandora-kernel.git pxa168: fix double deallocation of managed resources Commit 43d3ddf87a57 ("net: pxa168_eth: add device tree support") starts to use managed resources by adding devm_clk_get() and devm_ioremap_resource(), but it leaves explicit iounmap() and clock_put() in pxa168_eth_remove() and in failure handling code of pxa168_eth_probe(). As a result double free can happen. The patch removes explicit resource deallocation. Also it converts clk_disable() to clk_disable_unprepare() to make it symmetrical with clk_prepare_enable(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: David S. Miller --- Reading git-diff-tree failed