From: Yannic Moog Date: Fri, 13 Jun 2025 12:02:45 +0000 (+0200) Subject: binman: test: assert optional blobs don't cause non-functionality X-Git-Tag: v2025.10-rc1~91^2~32^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0dbb0a8d1f2aefb2a7fdd8e627edd955e4fe8d3a;p=pandora-u-boot.git binman: test: assert optional blobs don't cause non-functionality When external blobs are marked optional, they should not cause a build to fail. Extend the test cases for FitTeeOsOptional and ExtblobOptional. Reviewed-by: Simon Glass Signed-off-by: Yannic Moog Reviewed-by: Bryan Brattlof --- diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index 32e1e0a14c0..bedfcb53c48 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py @@ -6518,6 +6518,9 @@ fdt fdtmap Extract the devicetree blob from the fdtmap self.assertRegex( err, "Image '.*' is missing optional external blobs but is still functional: tee-os") + self.assertNotRegex( + err, + "Image '.*' has faked external blobs and is non-functional: tee-os") def testFitTeeOsOptionalFitBad(self): """Test an image with a FIT with an optional OP-TEE binary""" @@ -6551,6 +6554,19 @@ fdt fdtmap Extract the devicetree blob from the fdtmap self.assertEqual(REFCODE_DATA, data) self.assertNotIn(MISSING_DATA, data) + def testExtblobFakedOptional(self): + """Test an image with an external blob that is optional""" + with terminal.capture() as (stdout, stderr): + data = self._DoReadFile('266_blob_ext_opt.dts') + self.assertEqual(REFCODE_DATA, data) + err = stderr.getvalue() + self.assertRegex( + err, + "Image '.*' is missing optional external blobs but is still functional: missing") + self.assertNotRegex( + err, + "Image '.*' has faked external blobs and is non-functional: missing") + def testSectionInner(self): """Test an inner section with a size""" data = self._DoReadFile('267_section_inner.dts')