From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Tue, 3 Aug 2010 01:33:26 +0000 (-0700)
Subject: Input: adp5588-keypad - fix NULL dereference in adp5588_gpio_add()
X-Git-Tag: v2.6.36-rc1~581^2^2
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d87c7228a49e8342d60dd552892e470e0b291fa;p=pandora-kernel.git

Input: adp5588-keypad - fix NULL dereference in adp5588_gpio_add()

The kpad structure is assigned to i2c client via i2s_set_clientdata()
at the end of adp5588_probe(), but in adp5588_gpio_add() we tried to
access it (via dev_get_drvdata! which is not nice at all) causing an
oops.

Let's pass pointer to kpad directly into adp5588_gpio_add() and
adp5588_gpio_remove() to avoid accessing driver data before it is
set up.

Also split out building of gpiomap into a separate function to
clear the logic.

Reported-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

Reading git-diff-tree failed