From: J. Bruce Fields Date: Wed, 8 May 2013 22:05:41 +0000 (-0400) Subject: security: cap_inode_getsecctx returning garbage X-Git-Tag: v3.11-rc1~32^2~29 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0d422afb892e3f993cf934b76a2c2ef839c446e0;p=pandora-kernel.git security: cap_inode_getsecctx returning garbage We shouldn't be returning success from this function without also filling in the return values ctx and ctxlen. Note currently this doesn't appear to cause bugs since the only inode_getsecctx caller I can find is fs/sysfs/inode.c, which only calls this if security_inode_setsecurity succeeds. Assuming security_inode_setsecurity is set to cap_inode_setsecurity whenever inode_getsecctx is set to cap_inode_getsecctx, this function can never actually called. So I noticed this only because the server labeled NFS patches add a real caller. Acked-by: Serge E. Hallyn Signed-off-by: J. Bruce Fields --- Reading git-diff-tree failed