From: Julia Lawall Date: Thu, 12 Jan 2012 09:55:14 +0000 (+0100) Subject: arch/powerpc/sysdev/fsl_pci.c: add missing iounmap X-Git-Tag: v3.3-rc2~36^2~4^2~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0cf572dc00cd36250af9260377a0b5faac9b3284;p=pandora-kernel.git arch/powerpc/sysdev/fsl_pci.c: add missing iounmap Add missing iounmap in error handling code, in a case where the function already preforms iounmap on some other execution path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; statement S,S1; int ret; @@ e = \(ioremap\|ioremap_nocache\)(...) ... when != iounmap(e) if (<+...e...+>) S ... when any when != iounmap(e) *if (...) { ... when != iounmap(e) return ...; } ... when any iounmap(e); // Signed-off-by: Julia Lawall Signed-off-by: Kumar Gala --- Reading git-diff-tree failed