From: Jack Morgenstein Date: Sun, 17 Jul 2011 10:46:47 +0000 (+0000) Subject: RDMA/cma: Avoid assigning an IS_ERR value to cm_id pointer in CMA id object X-Git-Tag: v3.1-rc1~314^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c9361fcdeccd316ed67d85aa819c08066964c5b;p=pandora-kernel.git RDMA/cma: Avoid assigning an IS_ERR value to cm_id pointer in CMA id object Avoid assigning an IS_ERR value to the cm_id pointer. This fixes a few anomalies in the error flow due to confusion about checking for NULL vs IS_ERR, and eliminates the need to test for the IS_ERR value every time we wish to determine if the cma_id object has a cm device associated with it. Also, eliminate the now-unnecessary procedure cma_has_cm_dev (we can check directly for the existence of the device pointer -- for a non-NULL check, makes no difference if it is the iwarp or the ib pointer). Finally, make a few code changes here to improve coding consistency. Signed-off-by: Jack Morgenstein Signed-off-by: Roland Dreier --- Reading git-diff-tree failed